Could you help me out with this? My workout schedule.?

Hi im trying to lose weight. On mon,wed,fri, i do upperbody strength (8reps,4sets, 3 rotations, shoulders, bicep, tricep) but before that i do 20-40laps of swimming. In tue,thur,sat, i do lower and chest ((( legs, chest ))). I drink whey protein 24g per scoop as soon as i wake up, and after i workout. I workout everyday at 6am. Im 16, 6'0 , 212lbs. If someone could tell me whats better or if im doing good, please say so. Im aiming towards 180lbs. I replace my breakfast with Protein shake and apple, Launch is something light and healthy, dinner is something light too. I drink a liter of water through out the day. Is this a effective way to lose weight? Treadmill or Elliptical are NOT my Favorites...